Skip to content

feat(code-review): add review analytics#4073

Draft
alex-alecu wants to merge 5 commits into
mainfrom
feat/code-review-analytics
Draft

feat(code-review): add review analytics#4073
alex-alecu wants to merge 5 commits into
mainfrom
feat/code-review-analytics

Conversation

@alex-alecu

@alex-alecu alex-alecu commented Jun 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Adds optional Code Reviewer analytics for personal and organization accounts.
  • Saves structured change and finding totals when a review finishes, while keeping retries and repeat callbacks safe.
  • Adds filters, coverage details, repository tables, and a GitHub organization contributor view.

Verification

  1. Open Code Reviewer settings for GitHub or GitLab and select the Analytics tab.
  2. Turn on analytics collection, complete a new review, and confirm its totals appear for the matching date and repository.
  3. Turn collection off and confirm saved analytics stay visible while new reviews are not added.
  4. For a GitHub organization, confirm members can view the dashboard but only owners and billing managers can change collection.

Visual Changes

Screen.Recording.2026-06-18.at.12.13.14.mov

Reviewer Notes

  • Collection is off by default and does not fill in old reviews.
  • Contributor rankings are limited to GitHub organizations because GitLab does not provide a stable author identity here.

@kilo-code-bot

kilo-code-bot Bot commented Jun 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

Incremental commit 12cf0a6 restructures the analytics breakdown cards into grid-based sections with improved accessibility (role=list/listitem, screen-reader summaries, useId-scoped heading IDs), introduces a reusable BreakdownCard with a matching skeleton, and adds a Storybook story; no critical findings.

Files Reviewed (3 files)
  • apps/storybook/stories/code-reviews/AnalyticsBreakdownBars.stories.tsx — new Populated and EmptyOptionalData stories
  • apps/web/src/components/code-reviews/analytics/AnalyticsBreakdownBars.tsx — split cards into ChangeProfileSection/FindingTaxonomySection with grids, BreakdownCard abstraction, accessibility improvements, useId
  • apps/web/src/components/code-reviews/analytics/CodeReviewAnalyticsPanel.tsx — AnalyticsBreakdownSkeletonCard helper and restructured loading state to match the new two-section grid layout
Previous Review Summaries (3 snapshots, latest commit a0ff158)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit a0ff158)

Status: No Issues Found | Recommendation: Merge

Executive Summary

Incremental commit a0ff158 refactors the contributor leaderboard to track PRs without critical findings (instead of without critical-or-warning findings), drops the numeric Rank column in favor of a per-row "Limited data" badge, and updates the router test accordingly; all changes are internally consistent with correct column counts and expected values.

Files Reviewed (3 files)
  • apps/web/src/components/code-reviews/analytics/AnalyticsTables.tsx — renames sortable column/key, removes Rank column, adjusts empty-state colSpan 9→8, relocates "Limited data" badge into the Author cell
  • apps/web/src/lib/code-reviews/analytics/db.ts — renames prsWithoutCriticalOrWarningFindings→prsWithoutCriticalFindings, narrows SQL FILTER to critical_findings = 0, removes rank computation
  • apps/web/src/routers/code-reviews/code-review-analytics-router.test.ts — adds a suggestion finding to a fixture, updates expected totals (totalFindings 4→5, suggestionFindings 1→2, prsWithoutCriticalFindings 3→4) and drops rank assertion

Previous review (commit f242b52)

Status: No Issues Found | Recommendation: Merge

Executive Summary

Incremental commit restricts Code Reviewer analytics to organization-owned reviews only; changes across UI, settings, dispatch, persistence, and router are internally consistent with adequate test coverage.

Files Reviewed (12 files)
  • CONTEXT.md - Updates Review Analytics scope language to organization-only
  • apps/web/src/app/(app)/code-reviews/ReviewAgentPageClient.tsx - Removes Analytics tab from personal review page
  • apps/web/src/components/code-reviews/analytics/AnalyticsTables.tsx - Drops organization_scope_required capability and optional organizationId prop
  • apps/web/src/components/code-reviews/analytics/CodeReviewAnalyticsPanel.tsx - Makes organizationId required
  • apps/web/src/lib/code-reviews/analytics/db.ts - Guards persistence against personal reviews; org-only dashboard queries
  • apps/web/src/lib/code-reviews/analytics/db.test.ts - Adds org setup and personal-review rejection test
  • apps/web/src/lib/code-reviews/analytics/settings.ts - Narrows ReviewAnalyticsOwner to org-only
  • apps/web/src/lib/code-reviews/analytics/settings.test.ts - Updates tests to org owners
  • apps/web/src/lib/code-reviews/dispatch/dispatch-pending-reviews.ts - Gates analytics enrollment on org owner
  • apps/web/src/lib/code-reviews/dispatch/dispatch-pending-reviews.test.ts - Adds personal-skip and org-keep tests
  • apps/web/src/routers/code-reviews/code-review-analytics-router.ts - Requires organizationId in schemas
  • apps/web/src/routers/code-reviews/code-review-analytics-router.test.ts - Adds org-scope requirement test

Previous review (commit 600b8c3)

Status: No Issues Found | Recommendation: Merge

Executive Summary

Adds opt-in Code Reviewer analytics with bounded taxonomy persistence, snapshot-based enrollment, and dashboard queries. No PII, GDPR, security, or data integrity concerns found.

Files Reviewed (29 files)
  • CONTEXT.md - Documentation: Code Reviewer terms, boundaries, and rules
  • apps/web/src/app/(app)/code-reviews/ReviewAgentPageClient.tsx - UI: Analytics tab for personal reviews
  • apps/web/src/app/(app)/organizations/[id]/code-reviews/ReviewAgentPageClient.tsx - UI: Analytics tab for org reviews
  • apps/web/src/app/api/internal/code-review-status/[reviewId]/route.ts - Callback: analytics manifest parsing and finalization
  • apps/web/src/app/api/internal/code-review-status/[reviewId]/route.test.ts - Tests
  • apps/web/src/components/code-reviews/analytics/AnalyticsBreakdownBars.tsx - New UI component
  • apps/web/src/components/code-reviews/analytics/AnalyticsTables.tsx - New UI component
  • apps/web/src/components/code-reviews/analytics/CodeReviewAnalyticsPanel.tsx - New UI component
  • apps/web/src/lib/agent-config/db/agent-configs.ts - Config: review_analytics_enabled field in JSONB
  • apps/web/src/lib/code-reviews/analytics/contracts.ts - Validation schemas, manifest parser, prompt appendix
  • apps/web/src/lib/code-reviews/analytics/contracts.test.ts - Tests
  • apps/web/src/lib/code-reviews/analytics/db.ts - Persistence: results, findings, dashboard queries
  • apps/web/src/lib/code-reviews/analytics/db.test.ts - Tests
  • apps/web/src/lib/code-reviews/analytics/settings.ts - Analytics enable/disable settings
  • apps/web/src/lib/code-reviews/analytics/settings.test.ts - Tests
  • apps/web/src/lib/code-reviews/db/code-reviews.ts - Attempt creation with analytics snapshot
  • apps/web/src/lib/code-reviews/db/code-reviews.test.ts - Tests
  • apps/web/src/lib/code-reviews/dispatch/dispatch-pending-reviews.ts - Analytics enrollment at dispatch
  • apps/web/src/lib/code-reviews/dispatch/dispatch-pending-reviews.test.ts - Tests
  • apps/web/src/routers/code-reviews-router.ts - Default review_analytics_enabled: false
  • apps/web/src/routers/code-reviews-router.test.ts - Tests
  • apps/web/src/routers/code-reviews/code-review-analytics-router.ts - New tRPC router
  • apps/web/src/routers/code-reviews/code-review-analytics-router.test.ts - Tests
  • apps/web/src/routers/code-reviews/code-reviews-router.ts - Router registration
  • apps/web/src/routers/organizations/organization-code-reviews-router.ts - Org defaults
  • packages/db/src/migrations/0166_open_xorn.sql - New tables + column + FKs + indexes
  • packages/db/src/schema-types.ts - TypeScript types and Zod schemas
  • packages/db/src/schema.ts - Drizzle table definitions
  • packages/db/src/schema.test.ts - Schema tests

Reviewed by glm-5.2-20260616 · 250,545 tokens

Review guidance: REVIEW.md from base branch main

@alex-alecu alex-alecu marked this pull request as draft June 18, 2026 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@alex-alecu